fix(i18n): complete translation coverage for all 12 supported languages - #149
Closed
Trovic1 wants to merge 1 commit into
Closed
fix(i18n): complete translation coverage for all 12 supported languages#149Trovic1 wants to merge 1 commit into
Trovic1 wants to merge 1 commit into
Conversation
- Add missing 'common.welcome' key to en, es, ar locale files - Create 9 new locale files: fr, de, he, ja, zh, pt, ru, it, ko - Add build-time translation key validation script (validate-i18n.js) - Add dev-mode console warning for missing translation keys in useInternationalization hook - Add validate:i18n npm script and integrate into validate command Close rinafcode#138
|
@Trovic1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
PLEASE FIX CI |
Contributor
Author
Ok will do now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes missing translation keys causing fallback to English by completing all locale files and adding build-time validation.
Changes
common.welcomewas referenced inExampleUsage.tsxbut never defined — added toen.json,es.json,ar.jsonfr.json,de.json,he.json,ja.json,zh.json,pt.json,ru.json,it.json,ko.json— all with complete 71-key parity againsten.jsonscripts/validate-i18n.jsthat compares all locale files againsten.jsonand fails (exit code 1) on missing/extra keyst()function inuseInternationalization.tsxnow logs a console warning when a key is missing during developmentvalidate:i18nand integrated into thevalidatecommandValidation
All 12 locales pass with 71/71 keys ✅
Impacted Files
src/locales/*.json(3 modified, 9 new)src/hooks/useInternationalization.tsxscripts/validate-i18n.js(new)package.jsonClose #138